Add optional onUserJoin and onUserLeave hooks #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philihp
reviewed
Jul 8, 2023
| } | ||
| sendSnapshot(roomId, userId); | ||
| const { impl, chance } = rooms.get(roomId)!; | ||
| impl._onUserJoin(userId, ctx(chance, Date.now(), roomId)); |
Contributor
There was a problem hiding this comment.
does this work if _onUserJoin is undefined? should it be
impl._onUserJoin?.(userId, ctx(chance, Date.now(), roomId));
Contributor
Author
There was a problem hiding this comment.
_onUserJoin is an internal function and should always be defined, and its job may be a no-op if the user's function is not defined. See the wrapper file.
philihp
reviewed
Jul 8, 2023
| subscribers.delete(userId); | ||
| if (subscribers.size === 0) { | ||
| const { impl, chance, subscriptions } = rooms.get(roomId)!; | ||
| impl._onUserLeave(userId, ctx(chance, Date.now(), roomId)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this would help resolve #196.
Adds optional
onUserJoinandonUserLeavemethods to theMethodsinterface which can be implemented inImplto react to users joining and leaving. This can be useful to clean upInternalStateimmediately when users leave.For example, the Uno demo could be updated to remove that user's entry from
handsin state if the user leaves (contrived example, obviously that wouldn't make sense in an IRL game of Uno because players can't really join/leave in the middle of a match).Implementation detail: I used
_prefixed methods in the wrapper because I think we should passthis.statethrough, and that seems to be the pattern used here.I didn't test this yet because I didn't look into how to use this repo as-is, so this is probably WIP if it needs tests added or some code to be generated.