Skip to content

Conversation

@austinbuckler
Copy link

@austinbuckler austinbuckler commented Jan 3, 2023

Copy link
Member

@hpx7 hpx7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks great, thanks!

Two requests:

  1. Can we rename siwe to etherum?
  2. Can we get rid of the new example app and instead add etherum as an auth option to an existing app (probably chat)?

@cooperate
Copy link

cooperate commented Feb 5, 2023

Mostly looks great, thanks!

Two requests:

  1. Can we rename siwe to etherum?
  2. Can we get rid of the new example app and instead add etherum as an auth option to an existing app (probably chat)?

I think we should stick with the nomenclature for siwe as people that will likely leverage this in the crypto-space will be familiar with the terminology.
https://github.com/spruceid/siwe

And yes I can refactor the example to be used in the chat example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants