ETT-799: update modal component with keyboard focus for download panel #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@moseshll sorry, I thought I tagged you on this one, but I see now that did not happen! 🤦♀️ Thanks in advance for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a companion to the page turner a11y bugs PR. This implements the event listener for closing the download modal.
There isn't really anything here to review unless you want to test this out in pt on dev-3: https://dev-3.babel.hathitrust.org/cgi/pt?id=mcg.ark:/13960/t6tx4zx69&seq=3
Open the download panel, click the Download button. Once the modal pops up, use your keyboard and press
ESC. The modal should close and the focus return to the Download button in the sidebar.