ETT-400 Change Credential Handling #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changes to DB credentials break a longstanding assumption that dev and prod DB passwords are the same.
- `CRMS::Config` module can now understand YAML subkeys that are {production, training, development}.
- I'd like to change over to `dotenv` or some other system but this is the least potentially disruptive.
…of `require_ok` in tests -- just use `use`.
… leverage config subkeys. - CRMS.pm no longer needs to explicitly choose dev host based on instance. - CRMS.pm no longer needs to explicitly choose training database name based on instance.
…re remnants of CRMS-US/CRMS-World separation.
mwarin
reviewed
Jul 3, 2025
mwarin
reviewed
Jul 3, 2025
mwarin
approved these changes
Jul 3, 2025
mwarin
left a comment
mwarin
left a comment
There was a problem hiding this comment.
I see nothing wrong here. Accidentally made a couple of comments as single comments, but meant for them to be part of the review.
Regardless, APPROVE!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRMS::Configmodule can now understand YAML subkeys that are {production, training, development}.Reviewer:
lib/CRMS/Auth.pm$Cthat gets passed around everywhere inbabel).