Adding support for automatically reloading the list files of dnsbl-lookup#3
Open
Sander-Kastelein wants to merge 2 commits intohassansin:masterfrom
Open
Adding support for automatically reloading the list files of dnsbl-lookup#3Sander-Kastelein wants to merge 2 commits intohassansin:masterfrom
Sander-Kastelein wants to merge 2 commits intohassansin:masterfrom
Conversation
Owner
|
That's a good point but watching files will also push callbacks in event loop and prevent nodejs from exiting normally. I think you should maintain a separate files for list instead of editing the default list files. Then call the lookup methods with the list argument each time those files have changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like this feature very much for my current project, I only require dnsbl-lookup once and the sysadmin would like to edit the JSON files without having to reboot the whole node process.