Skip to content

Adding support for automatically reloading the list files of dnsbl-lookup#3

Open
Sander-Kastelein wants to merge 2 commits intohassansin:masterfrom
Sander-Kastelein:master
Open

Adding support for automatically reloading the list files of dnsbl-lookup#3
Sander-Kastelein wants to merge 2 commits intohassansin:masterfrom
Sander-Kastelein:master

Conversation

@Sander-Kastelein
Copy link
Copy Markdown

I'd like this feature very much for my current project, I only require dnsbl-lookup once and the sysadmin would like to edit the JSON files without having to reboot the whole node process.

@hassansin
Copy link
Copy Markdown
Owner

That's a good point but watching files will also push callbacks in event loop and prevent nodejs from exiting normally. I think you should maintain a separate files for list instead of editing the default list files. Then call the lookup methods with the list argument each time those files have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants