Master #1
Open
Master #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the function asset_report__approve() performs exactly the same function, except that it works both for depreciation as well as disposal.
…preciation * Remove duplicate code (asset_depreciation__approve)
* Close ledgersmb#3363: Set trans_type_code on every GL table insert
* Re-indent payment.pm so I can actually read it
Note that this commit in fact does 4 things:
1. Reflow line length of both comments and code below 80 chars
2. Consolidate the main if/else branches into a single code path
3. Replace all dereferences of '$entity_list{$entity_id} with a variable
4. Move the final wrapping of fields for database into a loop
Note that this commit also factors out the common variable $ovp_inv_payment to help stay below 80 chars.
This removes the need for an additional level of indenting.
Refactor payment pm
…t screen Note that this approach also eliminates the need to have a (hidden) list of selected invoices, actually simplifying the list of posted values.
* Close ledgersmb#2432: Inverse meaning of checkmark on single payment screen
…e one Note that the absence of an 'id' attribute currently prevents tooltips from showing up.
…g to 1.4-default
Fix payment tooltips
* Re ledgersmb#2270, same as on 1.5 branch, revert currency formatting to 1.4-default
Fix Dojo documentation typo
Uses Uglify debian version
* Rollback during tests to prevent warning in Travis output
Note that the error was caused by a duplicate 'entity_id' field which this commit removes.
* Fix ledgersmb#3686: Failure to change groups of user in HR screen
[skip ci]
LedgerSMB->open_form() method accepted a `commit` argument, but this was neither used, nor documented, nor tested. It has been removed.
…_form-arg Remove unused/undocumented/untested commit arg from LedgerSMB->open_form()
Pod criticism
Note that before this commit, sometimes clicking the same menu link twice was ineffective. In 1.5, we used to have counter measures in place to make the URL in the window.location differ between clicks. This commit restores that counter measure.
* Fix ledgersmb#3704: Load pages when menu clicked twice
Note that many modules had SYNOPSIS sections which were used much the same way as 'regular' CPAN modules would use their DESCRIPTION sections. Those cases have been renamed to DESCRIPTION; later iterations will need to add a SYNOPSIS.
* Add/convert DESCRIPTION section in Perl modules
Note that the section is called METHODS/SUBFUNCTIONS in Damian's book Perl Best Practices, but the section is called INTERFACE in his module Module::Starter::PBP. As the module came later and the name INTERFACE makes more sense to me, we'll be using INTERFACE with subsections (ATTRIBUTES, METHODS, FUNCTIONS).
* Add tests for METHODS POD section
Note that the print button needs a specific cookie to be reset (=contain the value 'downloaded'). However, due to using 'header_set', the session setting AuthenticateSession middleware overwrites the download-cookie-resetting Set-Cookie header. Switching both to 'header_push' makes setting cookies an additive action.
* Fix ledgersmb#3705: Print button doesn't work more than once
[skip ci]
Note that it's sufficient to run a single update to update the positions of the menu items following the inserted position.
The problem we're fixing is that schema change 1.5/template_menu.sql and 1.5/template_menu3.sql (by consequence) fail to apply. The new script is much more careful to free positions in the menu and check for existence of nodes than the previous scripts. Note that the only way to add ACLs to menu items is through Roles.sql because upon creation of a new database, the function lsmb__role() hasn't been loaded into the schema yet, but it's return value in an existing schema may differ from the standard 'lsmb_<database>__'. Roles.sql takes care of all that for us.
Update mailing list urls from https://lists.sourceforge.net to https://lists.ledgersmb.org
…e-mailing-lists-urls Readme.md: mailing lists urls: lists.ledgersmb.org
Timeout 300 and ProxyTimeout 300 Fix for reverse proxy error, as where apache was only waiting 60 sec to timeout, even if global is set to 300
…dd-timeout-settings-#4416 Update apache-vhost.conf. Add timeout settings, closes ledgersmb#4416
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.