add instances and adjust comments on unlawfulness #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Currently updating the changelog, version and adding such instances to other strict types as well. |
Author
|
I'll have to do a major version bump of packages other than |
TeofilC
reviewed
Mar 25, 2024
TeofilC
reviewed
Mar 25, 2024
TeofilC
reviewed
Mar 25, 2024
TeofilC
reviewed
Mar 25, 2024
Benjamin-McRae-Tracsis
force-pushed
the
instances
branch
from
12659f2 to
2f9c6c8
Compare
phadej
requested changes
Mar 25, 2024
phadej
reviewed
Mar 25, 2024
adjust comment to link to instances Co-authored-by: Teo Camarasu <teofilcamarasu@gmail.com>
Co-authored-by: Teo Camarasu <teofilcamarasu@gmail.com>
Co-authored-by: Teo Camarasu <teofilcamarasu@gmail.com>
Co-authored-by: Teo Camarasu <teofilcamarasu@gmail.com>
Benjamin-McRae-Tracsis
force-pushed
the
instances
branch
from
208a6fa to
2b12245
Compare
phadej
reviewed
Mar 26, 2024
phadej
reviewed
Mar 26, 2024
This reverts commit 58ffeef.
Author
|
Hi, is there anything more I can do to help this PR along, or are you waiting until you're free to complete it? |
Contributor
That. |
Author
|
Hi, have you had any time to have a look at this? If not, let me know what I can do to help out. |
Author
|
Hi, is there anything I can do to help this along? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relating to #25