Remove deprecated modules #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I think the CI times out because the ubuntu version it uses is too old. |
Author
|
@phadej what do you think? |
Collaborator
|
There's little point of making a major / breaking release just for the sake cleanup. When there are some other reason to do breaking release, this can be included; until then it can wait (indefinitely). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the deprecated modules
Math.NumberTheory.Powers.IntegerandMath.NumberTheory.Powers.Natural. They have been deprecated since 2017 (#6), more than 8 years ago. I couldn't find any uses of these modules on Hackage (using https://hackage-search.serokell.io/) and migrating is easy (just use^).