Skip to content

Conversation

@TeofilC
Copy link
Collaborator

@TeofilC TeofilC commented Dec 17, 2025

We remove the parsing code for some old event types. We export some pattern synonyms for backwards compatibility. These will never successfully be matched against but it mean that end users wont have to update their code.

@wenkokke does this look OK in terms of minimizing breakage?

We remove the parsing code for some old event types.
We export some pattern synonyms for backwards compatibility.
These will never successfully be matched against but it mean that end
users wont have to update their code.
@TeofilC
Copy link
Collaborator Author

TeofilC commented Dec 17, 2025

Hmm looks like the pattern synonyms trick only works for recent GHCs :(

@wenkokke
Copy link
Contributor

Hmm looks like the pattern synonyms trick only works for recent GHCs :(

Is it just that DuplicateRecordFields isn't supported on those older versions or misbehaves when it comes to pattern synonyms?

@TeofilC
Copy link
Collaborator Author

TeofilC commented Dec 23, 2025

Is it just that DuplicateRecordFields isn't supported on those older versions or misbehaves when it comes to pattern synonyms?

It's older versions not supporting DuplicateRecordFields. I need that since otherwise I get errors because some of the pattern synonyms declare the same field names.

Dropping support for older versions soon wouldn't be too bad though. I doubt anyone actually uses new versions of this library with old versions of GHC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants