Skip to content

Use serveDirectoryFileServer#37

Open
k-bx wants to merge 1 commit intohaskell-servant:masterfrom
k-bx:patch-2
Open

Use serveDirectoryFileServer#37
k-bx wants to merge 1 commit intohaskell-servant:masterfrom
k-bx:patch-2

Conversation

@k-bx
Copy link
Copy Markdown

@k-bx k-bx commented Mar 18, 2019

Failed to build previously with:

examples/counter.hs:72:19: warning: [-Wdeprecations]
    In the use of ‘serveDirectory’
    (imported from Servant, but defined in Servant.Server.StaticFiles):
    Deprecated: "Use serveDirectoryFileServer instead"
   |
72 |              :<|> serveDirectory www -- serve static files
   |                   ^^^^^^^^^^^^^^

Failed to build previously
@phadej
Copy link
Copy Markdown
Contributor

phadej commented Mar 18, 2019

It did not fail. Warning is not a failure.

EDIT It really matters, as I thought there's actually a broken release. But there aren't.

@k-bx
Copy link
Copy Markdown
Author

k-bx commented Mar 18, 2019

@phadej sorry! My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants