Open
Conversation
This fix is ugly, It would be better to have a list of allowed command in cluster mode with a function to know which argument should be considered as the key. But as a quick fix to allow proper use of eval and evalsha command in cluster mode, it can do the job. It makes as much sense as supporting the multi interface as the lua script execution in redis is supported by cluster and the natural replacement for the multi interface in the future. It is also more performant. All the keys sent to the script should be on the same slot to get it to work (as for the multi interface) so just considering the first key if it exists is fine. In case of the other keys are not from the same slot, redis will return the cross slot error as usual. If there is no key for a script then we can let the hash of the script deciding on which node running it as it can be run freely on any node.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is ugly, It would be better to have a list of allowed command in cluster mode with a function to know which argument should be considered as the key. But as a quick fix to allow proper use of eval and evalsha command in cluster mode, it can do the job.
It makes as much sense as supporting the multi interface as the lua script execution in redis is supported by the cluster and the natural replacement for the multi interface in the future. It is also more performant.
All the keys sent to the script should be on the same slot to get it to work (as for the multi interface) so just considering the first key, if it is given, is fine. In case of the other keys are not from the same slot, redis will return the cross slot error as usual.
If there is no key for a script then we can let the hash of the script deciding on which node running it as it can be run freely on any node.