[Snyk] Security upgrade torch from 1.9.0 to 2.10.0#22
[Snyk] Security upgrade torch from 1.9.0 to 2.10.0#22hashim21223445 wants to merge 1 commit intomainfrom
Conversation
The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-TORCH-10332644 - https://snyk.io/vuln/SNYK-PYTHON-TORCH-10332645
Summary of ChangesHello @hashim21223445, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, upgrades torch from version 1.9.0 to 2.10.0 to fix security vulnerabilities. While this is a necessary security update, the new torch version is highly likely to be incompatible with the pinned torchvision==0.7.0 dependency, which will almost certainly break the application. I have added a critical comment highlighting this issue and recommending that torchvision be upgraded to a compatible version in conjunction with this change.
| @@ -1,2 +1,2 @@ | |||
| torch==1.9.0 | |||
| torch==2.10.0 | |||
There was a problem hiding this comment.
Upgrading torch to 2.10.0 introduces a critical compatibility issue with torchvision==0.7.0. The torchvision package version must be aligned with the torch version to prevent runtime errors. torchvision==0.7.0 was released for torch==1.6.0 and is incompatible with modern torch versions.
To resolve this, torchvision must also be upgraded to a compatible version. For example, torch 2.1.x is compatible with torchvision 0.16.x. Please update torchvision accordingly, otherwise the project is very likely to fail.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
distributed/rpc/pipeline/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Buffer Overflow