Harden VMCX support#8119
Merged
chrisroberts merged 1 commit intohashicorp:masterfrom Jan 5, 2017
bbrala:check-vmcx-support
Merged
Harden VMCX support#8119chrisroberts merged 1 commit intohashicorp:masterfrom bbrala:check-vmcx-support
chrisroberts merged 1 commit intohashicorp:masterfrom
bbrala:check-vmcx-support
Conversation
…upport for vmcx and then uses the VMCX file.
Contributor
Author
|
Welcome back @chrisroberts , hope you a good holiday :) |
ghost
locked and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vagrant now checks if your Windows version has support for VMCX and then uses the VMCX file.
The reason for this is because the support for HyperV in Packer is now merged, but, it always creates an XML file, I assume for backwards compatibility, which does make sense especially for Windows versions before 10 which are still used. Vagrant should prefer using the newer format when supported, even when the old XML format is available.
The check consists of checking if the Windows version is greater or equal to 10, since Windows 10, and Windows Server 2016 both use the binary format, and they won't change back to the old config in future releases I assume.
To test, I loaded up about 5 of the HyperV boxes on Atlas with 1.9.1 and with this branch. Everything went fine. In order to make possible future debugging easier I added the type of config that is loaded to the debug log.