Changes to policy storage and policy attachment files#604
Open
dannyjknights wants to merge 4 commits intomainfrom
Open
Changes to policy storage and policy attachment files#604dannyjknights wants to merge 4 commits intomainfrom
dannyjknights wants to merge 4 commits intomainfrom
Conversation
Dan-Heath
previously approved these changes
Apr 23, 2024
Contributor
Dan-Heath
left a comment
Dan-Heath
left a comment
There was a problem hiding this comment.
This looks good to me, thank you Danny!
Co-authored-by: Robin Beck <stellarsquall@users.noreply.github.com>
stellarsquall
requested changes
Apr 23, 2024
Co-authored-by: Robin Beck <stellarsquall@users.noreply.github.com>
Co-authored-by: Robin Beck <stellarsquall@users.noreply.github.com>
Collaborator
|
@dannyjknights do we still want to merge this? Might need a new push to rerun the tests but otherwise the added examples seem good |
Author
|
Yes please :) I thought it was already done to be honest |
louisruch
requested changes
Oct 28, 2024
Collaborator
There was a problem hiding this comment.
Ah I see the gen_delta is failing, the reason for this is that we cannot update the docs directly since they are generated instead we should create an corresponding file in https://github.com/hashicorp/terraform-provider-boundary/tree/main/examples/resources and then run make docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scope_policy_attachment.mdhad no description or example usage for attaching a storage policy. Thepolicy_storage.mdhad no example usage for creating a storage policy.