Skip to content

Conversation

@BrianMMcClain
Copy link
Contributor

  • Add hcp_sbom reference
  • Update provisioner overview page

ritsok
ritsok previously approved these changes Jan 21, 2025
Co-authored-by: rita <8647768+ritsok@users.noreply.github.com>
@lbajolet-hashicorp
Copy link
Contributor

Hey @BrianMMcClain,

I've seen this one pop this morning but am only commenting now (sorry), just to let you know, the documentation for this feature is baked into the PR that introduces the code for the feature (in a separate branch, refer to PR #13171, which is still marked as [POC], but is very much not anymore so).
Regarding those documentation changes, would it be possible to amend this PR instead?

Co-authored-by: rita <8647768+ritsok@users.noreply.github.com>
@BrianMMcClain BrianMMcClain changed the base branch from main to poc/provisioner-hcp-sbom January 21, 2025 16:05
@BrianMMcClain BrianMMcClain marked this pull request as draft January 21, 2025 16:05
@BrianMMcClain
Copy link
Contributor Author

Hey @BrianMMcClain,

I've seen this one pop this morning but am only commenting now (sorry), just to let you know, the documentation for this feature is baked into the PR that introduces the code for the feature (in a separate branch, refer to PR #13171, which is still marked as [POC], but is very much not anymore so). Regarding those documentation changes, would it be possible to amend this PR instead?

@lbajolet-hashicorp Ah good call, totally missed there were docs included in that draft, my bad! Closing this one and drafting a new PR against that branch now :)

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants