fix(ui): use deterministic timestamps in dynamic host volume Percy test#27553
Draft
fix(ui): use deterministic timestamps in dynamic host volume Percy test#27553
Conversation
6a384cc to
7060c38
Compare
7060c38 to
9162fc4
Compare
9162fc4 to
b14b633
Compare
b14b633 to
e6f71c5
Compare
e6f71c5 to
8744e85
Compare
Pin allocation createTime/modifyTime to fixed values and freeze moment.now to a matching reference point so both absolute dates and relative times are identical across Percy snapshot runs.
8744e85 to
e144684
Compare
philrenaud
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes flaky Percy snapshot tests, Percy visual diffs from random Mirage data, and consistently failing "clicking legend item" tests for sysbatch/parameterized child jobs.
faker.date.past()with fixed timestamps in the dynamic host volume detail test. Freezemoment.nowduring the snapshot (wrapped intry/finallyfor safety).allocStatusDistributionto child jobs for periodic/parameterized parents. Children received random allocation statuses instead of the parent's{ running: 1 }, sometimes producing all "queued" allocations that made the clickable legend selector returnnull.percySnapshot(assert)multiple times in the same test produced duplicate names. Added explicit unique names inactions-test.js,jobs-list-test.js, andsentinel-policies-test.js.faker.seed(1)before Percy snapshots across 11 test files to ensure deterministic Mirage data (job names, priorities, task groups, allocation bars, etc.). Seeds are placed in individual test bodies orbeforeEachhooks close to the snapshots that need them, avoiding interference with unrelated tests in the same module.Testing & Reproduction steps
Cannot read properties of null (reading 'parentElement').Links
Contributor Checklist
Reviewer Checklist
Changes to Security Controls
No changes to security controls.