Skip to content

Comments

refactor(ui): replace dynamic component invocations with explicit conditionals#27527

Draft
aklkv wants to merge 1 commit intomainfrom
ember-upgrade/dynamic-component-invocations
Draft

refactor(ui): replace dynamic component invocations with explicit conditionals#27527
aklkv wants to merge 1 commit intomainfrom
ember-upgrade/dynamic-component-invocations

Conversation

@aklkv
Copy link
Contributor

@aklkv aklkv commented Feb 17, 2026

Description

Phase 0.10 of the Ember upgrade plan — remove Embroider-incompatible patterns:

  • Replace {{component (concat ...)}} in app-breadcrumbs and job-editor with explicit {{#if (eq ...)}} and angle bracket component invocations
  • Replace deprecated <LinkTo @params> with @route/@models in breadcrumbs/default
  • Replace (action ...) helper with direct references and {{fn}}
  • Remove .firstObject array prototype extension usage
  • Replace onchange={{action ...}} with {{on "change" ...}} modifier
  • Fix implicit this fallback and unnecessary curly braces in tests
  • Modernize run.later import to later in allocation-detail-test
  • Update jsconfig.json with proper paths and include/exclude
  • Replace broken local:qunitdom script with local:test

Testing & Reproduction steps

Links

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad product documentation, which is stored in the
    web-unified-docs repo. Refer to the web-unified-docs contributor guide for docs guidelines.
    Please also consider whether the change requires notes within the upgrade
    guide
    . If you would like help with the docs, tag the nomad-docs team in this PR.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.
  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

@aklkv aklkv self-assigned this Feb 17, 2026
@aklkv aklkv requested review from a team as code owners February 17, 2026 09:50
@aklkv aklkv marked this pull request as draft February 17, 2026 09:51
…ditionals

Phase 0.10 of the Ember upgrade plan — remove Embroider-incompatible patterns:

- Replace `{{component (concat ...)}}` in app-breadcrumbs and job-editor
  with explicit `{{#if (eq ...)}}` and angle bracket component invocations
- Replace deprecated `<LinkTo @params>` with `@route`/`@models` in
  breadcrumbs/default
- Replace `(action ...)` helper with direct references and `{{fn}}`
- Remove `.firstObject` array prototype extension usage
- Replace `onchange={{action ...}}` with `{{on "change" ...}}` modifier
- Fix implicit `this` fallback and unnecessary curly braces in tests
- Modernize `run.later` import to `later` in allocation-detail-test
- Update jsconfig.json with proper paths and include/exclude
- Replace broken local:qunitdom script with local:test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants