Skip to content

fix goroutine leak on fetch sleep for write requests #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WRABZY wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix goroutine leak on fetch sleep for write requests #2124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dependency/vault_pki.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,12 @@ func (d *VaultPKIQuery) Fetch(clients *ClientSet, opts *QueryOptions) (interface
}
select {
case dur := <-d.sleepCh:
time.Sleep(dur)
select {
case <-time.After(dur):
break
case <-d.stopCh:
return nil, nil, ErrStopped
}
default:
}

Expand Down
7 changes: 6 additions & 1 deletion dependency/vault_write.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,12 @@ func (d *VaultWriteQuery) Fetch(clients *ClientSet, opts *QueryOptions,
}
select {
case dur := <-d.sleepCh:
time.Sleep(dur)
select {
case <-time.After(dur):
break
case <-d.stopCh:
return nil, nil, ErrStopped
}
default:
}

Expand Down