change: use vault ttl for all non-lease secrets#2040
Open
EtienneBruines wants to merge 1 commit intohashicorp:mainfrom
Open
change: use vault ttl for all non-lease secrets#2040EtienneBruines wants to merge 1 commit intohashicorp:mainfrom
EtienneBruines wants to merge 1 commit intohashicorp:mainfrom
Conversation
Not all Vault secrets report back a `rotation_period`, but as long as they do not have a lease (for renewal) and report a `ttl`, we should be able to use the `ttl` value to determine the sleep duration. Fixes hashicorp#1970
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all Vault secrets report back a
rotation_period, but as long as they do not have a lease (for renewal) and report attl, we should be able to use thettlvalue to determine the sleep duration.Fixes #1970