Add optional delete flag for destination key deletion #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made to provide a more effective approach to handling consul-replicate key deletions. In the previous PR, the operator would be prompted to confirm if deletion should be initiated for destination keys that corresponded to removed source keys. This would be an issue if consul-replicate was daemonized, where there isn't a way to input an answer to the prompt.
This solution will allow operators to set a delete flag when starting consul-replicate from an interactive shell or for a daemon.
Example:
Deleting keys in source DC
Running
consul-replicate -config "replicate.hcl" -delete=falsein destination DC.