Added support for namespaces and adminPartitions#42
Open
Ganeshrockz wants to merge 5 commits intomasterfrom
Open
Added support for namespaces and adminPartitions#42Ganeshrockz wants to merge 5 commits intomasterfrom
Ganeshrockz wants to merge 5 commits intomasterfrom
Conversation
hanshasselberg
approved these changes
Jun 12, 2023
Member
hanshasselberg
left a comment
There was a problem hiding this comment.
LGTM, thanks for your work. My comments are no blockers, but I think it would be nice if Namespace and Partition are consistently (in CatalogDeregistration and CatalogRegistration or in AgentService) set only once across this PR.
Author
|
@hanshasselberg Thanks for the review. I removed the additional I guess we should have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
-consul-namespaceand-consul-admin-partitionflags to the existingconsul-awscommand. This will enable Consul enterprise users to sync their AWS to custom namespaces and admin partitions and vice versa. The default value for both these fields is an empty string and so there should be no changes in experience for non enterprise use cases.-aws-prefixflag is non empty. Because of this bug, the existing integration test was a bit flakyGoversion of this repo to1.20