fix: restore publishable cisco extra metadata#42
Merged
kantorcodes merged 2 commits intomainfrom Apr 4, 2026
Merged
Conversation
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request updates the cisco-ai-skill-scanner dependency from a git-based fork to a stable version (2.0.7) from PyPI and performs a minor downgrade of litellm to version 1.82.3. The reviewer suggested improving maintainability by dynamically extracting the cisco-ai-skill-scanner version from pyproject.toml within the GitHub Action, rather than hardcoding it, and provided corresponding updates for the test suite.
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (6 files)
Reviewed by minimax-m2.5-20260211 · 118,507 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cisco-ai-skill-scanner==2.0.7packageuv.lockand keep the Cisco-enabled scan path covered by the existing action-bundle regression checksVerification
uv sync --frozen --extra dev --extra cisco --group publish./.venv/bin/ruff check ../.venv/bin/pytest -q./.venv/bin/python -m build./.venv/bin/python -m twine check dist/*./.venv/bin/codex-plugin-scanner scan tests/fixtures/good-plugin --format json --cisco-skill-scan on --cisco-policy balancedRequires-Distnow containscisco-ai-skill-scanner==2.0.7instead of a direct Git URL