feat: validate official marketplace source objects#40
Merged
kantorcodes merged 4 commits intomainfrom Apr 4, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the marketplace validation logic, simplifying the check functions and enforcing a schema that requires local sources. The review feedback identifies several missing type checks for plugin entries that could lead to runtime errors and highlights inconsistencies in success and remediation messages regarding the support for remote URLs and required fields like 'category'.
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewAll previously reported issues have been addressed in the latest commits. The code now includes proper type checks for plugin entries in all three validation functions. Files Reviewed (3 files)
Resolved Issues (from previous review)
Reviewed by minimax-m2.5-20260211 · 498,966 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification