Skip to content

feat: validate official marketplace source objects#40

Merged
kantorcodes merged 4 commits intomainfrom
feat/marketplace-json-validation
Apr 4, 2026
Merged

feat: validate official marketplace source objects#40
kantorcodes merged 4 commits intomainfrom
feat/marketplace-json-validation

Conversation

@kantorcodes
Copy link
Copy Markdown
Member

Summary

  • validate the official marketplace.json source object shape from the Codex curated marketplace spec
  • require category metadata alongside installation and authentication policy
  • tighten local-path safety checks and cover the new source contract in tests

Verification

  • python3 -m pytest tests/test_marketplace.py -q

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the marketplace validation logic, simplifying the check functions and enforcing a schema that requires local sources. The review feedback identifies several missing type checks for plugin entries that could lead to runtime errors and highlights inconsistencies in success and remediation messages regarding the support for remote URLs and required fields like 'category'.

Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot bot commented Apr 4, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

All previously reported issues have been addressed in the latest commits. The code now includes proper type checks for plugin entries in all three validation functions.

Files Reviewed (3 files)
  • src/codex_plugin_scanner/checks/marketplace.py - No new issues
  • tests/fixtures/with-marketplace/marketplace.json - No issues
  • tests/test_marketplace.py - No issues

Resolved Issues (from previous review)

File Line Status
marketplace.py 119 Fixed - Type check added for plugin entries
marketplace.py 222 Fixed - Type check added for plugin entries
marketplace.py 288 Fixed - Type check added for plugin entries
marketplace.py 251 Fixed - Remediation now includes category field
marketplace.py 305 Fixed - Success message updated to match logic
marketplace.py 321 Fixed - Remediation message updated

Reviewed by minimax-m2.5-20260211 · 498,966 tokens

@kantorcodes kantorcodes merged commit f1757d7 into main Apr 4, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant