Skip to content

fix the linter error (prealloc) #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
votdev merged 1 commit into from
Jan 13, 2026
Merged

fix the linter error (prealloc) #131

votdev merged 1 commit into from
Jan 13, 2026
+5 −5

Conversation

@votdev
Copy link
Member

@votdev votdev commented Jan 12, 2026 •
edited
Loading

Problem:
Make validate reports errors from linter.

 Running validation
Running: golangci-lint run
tests/setup/harvester_mock.go:85:6: Consider preallocating results with capacity 1 (prealloc)
	var results []*extv1.CustomResourceDefinition
	    ^
1 issues:
* prealloc: 1

Solution:
Fix the linter error.

Related Issue:

Test plan:

@votdev votdev self-assigned this Jan 12, 2026
Copilot AI review requested due to automatic review settings January 12, 2026 10:53
Copilot AI reviewed Jan 12, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a prealloc linter error by refactoring the generateK8sCniCncfIoCRD() function to avoid unnecessary slice allocation and append operations.

Changes:

  • Replaced the pattern of declaring an empty slice and then appending to it with a direct return of a slice composite literal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@votdev
fix the linter error (prealloc)
b89d1cd 
Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev merged commit 27ede31 into harvester:main Jan 13, 2026
6 checks passed
@votdev votdev deleted the fix_lint_errors branch January 13, 2026 10:32
@starbops
Copy link
Member

starbops commented Jan 22, 2026

@mergify backport v1.7

@mergify
Copy link

mergify bot commented Jan 22, 2026 •
edited
Loading

backport v1.7

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jan 22, 2026
@votdev @mergify
fix the linter error (prealloc) (#131)
dc3cdad 
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 27ede31)
@mergify mergify bot mentioned this pull request Jan 22, 2026
Merged
starbops pushed a commit that referenced this pull request Jan 22, 2026
@votdev @starbops
fix the linter error (prealloc) (#131)
946dca7 
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 27ede31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@starbops starbops starbops approved these changes

@FrankYang0529 FrankYang0529 Awaiting requested review from FrankYang0529

@ibrokethecloud ibrokethecloud Awaiting requested review from ibrokethecloud

Assignees

@votdev votdev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@votdev @starbops