Skip to content

Conversation

@irishgordo
Copy link
Contributor

@irishgordo irishgordo commented Jan 23, 2026

  • pin setuptools
  • tests run but issue is Refrain from using this package or pin to Setuptools<81

Resolves: fix/harvester-baremetal-ansible-issue-160

Relates to: https://github.com/harvester/harvester-baremetal-ansible/issues/160

Signed-off-by: Mike Russell michael.russell@suse.com

Which issue(s) this PR fixes:

https://github.com/harvester/harvester-baremetal-ansible/issues/160

What this PR does / why we need it:

https://github.com/harvester/harvester-baremetal-ansible/issues/160

Special notes for your reviewer:

TEST:

  1. pip install -r test-requirements.txt
  2. pip freeze --all | grep -ie "setuptools" , should be less than 81

Additional documentation or context

https://github.com/harvester/harvester-baremetal-ansible/issues/160

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #160 by pinning setuptools to a version below 81 in the test environment to avoid known incompatibilities.

Changes:

  • Add an upper-bound pin setuptools < 81 to test-requirements.txt to comply with the guidance "Refrain from using this package or pin to Setuptools<81".

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jbrockmeyer
jbrockmeyer previously approved these changes Jan 23, 2026
@irishgordo irishgordo force-pushed the fix/harvester-baremetal-ansible-issue-160 branch from cd77e9a to 6eb56ee Compare January 23, 2026 17:33
jbrockmeyer
jbrockmeyer previously approved these changes Jan 23, 2026
* pin setuptools
* tests run but issue is `Refrain from using this package or pin to Setuptools<81`
* remove duplicates (requests, pyyaml)
Resolves: fix/harvester-baremetal-ansible-issue-160
Relates to: harvester/harvester-baremetal-ansible#160
Signed-off-by: Mike Russell <michael.russell@suse.com>
@irishgordo irishgordo force-pushed the fix/harvester-baremetal-ansible-issue-160 branch from 6eb56ee to a4c131c Compare January 23, 2026 18:16
@lanfon72
Copy link
Member

Justin already submitted the PR #2424 to fix this.

@irishgordo
Copy link
Contributor Author

@lanfon72 Okay I'll close this out in favor of @asc5543 's PR.
Was thinking that it would need to be even lower - but Justin's PR I guess addresses stuff with distutils too? 🤔 - as we're using Python3.10 in the pipeline, some version less than setuptools < 69 if we wanted to postpone code changes further likely would work.
I'll reopen this or we can investigate if the other PR doesn't entirely fix the pipeline 😄

@irishgordo irishgordo closed this Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants