Add retry to avoid race condition to fix 2376 #2411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: asc5543 <asc5543@gmail.com>
Signed-off-by: asc5543 <asc5543@gmail.com>
Signed-off-by: asc5543 <asc5543@gmail.com>
Contributor
Author
|
The CodeFactor fail because in test_9_rancher_integration, both rke1 and rke2 have test_create_pvc, and there are the same test steps. |
albinsun
approved these changes
Jan 20, 2026
Contributor
|
thanks for this fix 😄 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue #2376
What this PR does / why we need it:
test_9_rancher_integration.py::TestResourceQuota::test_create_namespace_on_project will encounter race condition during test, which cause KeyError when attempting to get data['metadata']['annotations']['field.cattle.io/resourceQuota']