common: fix linter

[Vicente-Cheng]

Problem:
fix linter for v1.7

Solution:
fix linter for v1.7

Related Issue:

Test plan:

[Copilot]

Pull request overview

This PR addresses linter warnings (specifically the prealloc warning) for v1.7 by refactoring slice allocations to use proper pre-allocation instead of suppressing warnings with nolint comments.

Changes:

• Replaced slice literal assignments with pre-allocated slices using make() with appropriate capacity
• Removed nolint: prealloc comments that were suppressing linter warnings
• Removed unused path/filepath import after switching from filepath.Join to string concatenation

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
pkg/utils/command.go	Pre-allocated cmdArgs slice and replaced filepath.Join with string concatenation for namespace paths
cmd/node-disk-manager-webhook/main.go	Pre-allocated starters slice with capacity 4 and moved declaration after error checks

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Replacing filepath.Join with string concatenation introduces a subtle change in path construction. Since exec.namespace comes from GetHostNamespacePath which returns paths ending with "/" (e.g., "/proc/1/ns/"), the new code produces paths like "/proc/1/ns//mnt" with double slashes, whereas filepath.Join would have produced "/proc/1/ns/mnt". While Linux generally tolerates double slashes, this behavioral change is unintended. To properly address the linter warning while maintaining exact behavior, consider using pre-allocated slices with filepath.Join, or ensure exec.namespace is trimmed of trailing slashes before concatenation.

[Vicente-Cheng]

@Mergifyio backport v1.7

[mergify]

backport v1.7

✅ Backports have been created

Details

• #263 common: fix linter (backport #262) has been created for branch v1.7 but encountered conflicts

Cherry-pick of a4796fd has failed:

On branch mergify/bp/v1.7/pr-262
Your branch is up to date with 'origin/v1.7'.

You are currently cherry-picking commit a4796fd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   cmd/node-disk-manager-webhook/main.go
	both modified:   pkg/utils/command.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally