Skip to content

Conversation

@Yu-Jack
Copy link
Collaborator

@Yu-Jack Yu-Jack commented Jan 21, 2026

Problem:

Solution:

Related Issue(s):

Test plan:

Additional documentation or context

@Yu-Jack Yu-Jack self-assigned this Jan 21, 2026
@github-actions
Copy link

github-actions bot commented Jan 21, 2026

Name Link
🔨 Latest commit 24a36c8
😎 Deploy Preview https://6972e5dafd33589337c5cc61--harvester-preview.netlify.app

@Yu-Jack Yu-Jack marked this pull request as ready for review January 21, 2026 06:54
Copilot AI review requested due to automatic review settings January 21, 2026 06:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation for a known upgrade issue related to the cpu-feature.node.kubevirt.io/ipred-ctrl=true CPU feature that appears during upgrades from v1.5.x to v1.6.x on specific Intel Xeon CPU models. The documentation provides workarounds for users before and after the upgrade.

Changes:

  • Added a new section (§8) documenting the ipred-ctrl CPU feature issue during upgrades
  • Updated subsequent section numbering (previous §8 becomes §9)
  • Provided specific CPU models affected and multiple resolution options

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/upgrade/v1-5-x-to-v1-6-x.md Added new section 8 documenting ipred-ctrl CPU feature issue and renumbered subsequent sections
versioned_docs/version-v1.6/upgrade/v1-5-x-to-v1-6-x.md Added identical documentation for v1.6 versioned docs
versioned_docs/version-v1.7/upgrade/v1-5-x-to-v1-6-x.md Added identical documentation for v1.7 versioned docs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

**After the upgrade:**
- Reboot the virtual machines.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if node-labeller was disabled, then VM's do not need to rebooted after the upgrade as selector labels matching cpu features will not have changed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, done!

ibrokethecloud
ibrokethecloud previously approved these changes Jan 22, 2026
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done

ihcsim
ihcsim previously approved these changes Jan 22, 2026
@Yu-Jack Yu-Jack dismissed stale reviews from ihcsim and ibrokethecloud via b34ace1 January 23, 2026 02:58
Yu-Jack and others added 7 commits January 23, 2026 11:03
Signed-off-by: Jack Yu <jack.yu@suse.com>
Co-authored-by: Gaurav Mehta <gaurav.mehta@suse.com>
Signed-off-by: Jack Yu <jack.yu@suse.com>
Signed-off-by: Jack Yu <jack.yu@suse.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com>
Signed-off-by: Jack Yu <jack.yu@suse.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com>
Signed-off-by: Jack Yu <jack.yu@suse.com>
Co-authored-by: Jillian Maroket <67180770+jillian-maroket@users.noreply.github.com>
Signed-off-by: Jack Yu <jack.yu@suse.com>
Signed-off-by: Jack Yu <jack.yu@suse.com>
@Yu-Jack Yu-Jack merged commit 04bbd59 into harvester:main Jan 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants