Skip to content

Add disks labels to provisioned disks (POSTPONE to v1.6.0) #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
torchiaf wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add disks labels to provisioned disks (POSTPONE to v1.6.0) #951

torchiaf wants to merge 2 commits into from

Conversation

@torchiaf
Copy link
Collaborator

@torchiaf torchiaf commented Feb 8, 2024 •
edited
Loading

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Fixes harvester/harvester#2770

Occurred changes and/or fixed issues

Technical notes summary

It adds disk tags to provisioned disks when saving.

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Details page

image

Config page

image

Edit page

image

@torchiaf torchiaf marked this pull request as ready for review February 28, 2024 19:12
@torchiaf torchiaf force-pushed the 2770-disks-labels branch from 5f74181 to d4fa8c8 Compare June 25, 2024 14:14
@torchiaf torchiaf requested a review from a110605 June 25, 2024 14:29
@torchiaf
Copy link
Collaborator Author

torchiaf commented Jun 25, 2024 •
edited
Loading

I've finalized this PR. Could you please tests it with witness node @a110605 ?

@torchiaf torchiaf changed the title 2770 disks labels Add disks labels to provisioned disks Jun 26, 2024
@a110605 a110605 added the Enhancement minor or greater UI enhancement label Aug 26, 2024
@bk201 bk201 mentioned this pull request Feb 14, 2025
Open
@torchiaf
Add tags for blockDevices disks
1b61adf 
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf
Apply disks changes when retrying save requests
828c213 
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@a110605 a110605 changed the title Add disks labels to provisioned disks Add disks labels to provisioned disks (POSTPONE to v1.6.0) Feb 19, 2025
@torchiaf torchiaf assigned a110605 and unassigned torchiaf Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a110605 a110605 Awaiting requested review from a110605

At least 1 approving review is required to merge this pull request.

Assignees

@a110605 a110605

Labels

Enhancement minor or greater UI enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] When adding a block device on the host page should support adding disk tags

2 participants

@torchiaf @a110605