Replace vue.extend with defineComponent in Harvester
#937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
contributes to rancher#10104
This replaces the usage of
Vue.extendwithdefineComponentin Harvester.defineComponentprovides better type inference, improved TypeScript support, and will be the recommended way to define components when Dashboard migrates to Vue 3.Occurred changes and/or fixed issues
Vue.extendwithdefineComponentfor components located underpkg/harvesterAreas or cases that should be tested
This has a broad reach across dashboard. Ideally, we will want to test multiple cases where the following components have been altered:
see original PR in dashboard repo rancher#10248