update configuration and values as per kubeovn v1.15.0 #461
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Kubeovn operator Helm charts to align with upstream Kubeovn v1.15.0, upgrading from v1.14.10. The update introduces new configuration options for CNI behavior, DNS resolution, load balancer preferences, and network policy enforcement while removing deprecated fields.
Changes:
- Added support for non-primary CNI configuration with new
nonPrimaryCnifield - Introduced three new component configuration options:
enableDNSNameResolver,enableOvnLbPreferLocal, andnpEnforcement - Added
skipConnectionTrackDstCIDRsnetworking configuration option - Removed deprecated
supportArmandthirdPartyimage configuration fields - Fixed incorrect field reference for
OVSDBConTimeoutin configuration template
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/kubeovn-operator/values.yaml | Updated default values to include new v1.15.0 configuration fields and removed deprecated image options |
| charts/kubeovn-operator/templates/configuration.yaml | Added template references for new configuration fields, fixed OVSDBConTimeout field reference bug |
| charts/kubeovn-operator-crd/templates/crd.yaml | Extended CRD schema with new field definitions for v1.15.0 features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| enableDNSNameResolver: | ||
| default: false | ||
| type: boolean | ||
| enableOvnLbPreferLocal: | ||
| default: false | ||
| type: boolean | ||
| npEnforcement: | ||
| default: standard | ||
| type: string |
There was a problem hiding this comment.
The fields supportArm and thirdParty were removed from values.yaml and configuration.yaml template as part of the upgrade to kubeovn v1.15.0, but they still exist in the CRD schema at lines 217-218 and 222-224. These fields should also be removed from the CRD to maintain consistency across all configuration files and properly reflect the v1.15.0 schema changes.
| cniConfigDir: /etc/cni/net.d | ||
| cniConfigPriority: "90" | ||
| localBinDir: /usr/local/bin | ||
| nonPrimaryCni: {{ .Values.configurationSpec.cniConf.nonPrimaryCni | default false }} |
There was a problem hiding this comment.
The nonPrimaryCni field has inconsistent default values across files. In values.yaml it's set to true, but the configuration.yaml template uses default false as fallback. This could lead to unexpected behavior if values are not explicitly set. Consider aligning the defaults - if the intention is for Harvester to use kubeovn as a non-primary CNI (as suggested in the test plan), the template default should be true to match values.yaml.
| nonPrimaryCni: {{ .Values.configurationSpec.cniConf.nonPrimaryCni | default false }} | |
| nonPrimaryCni: {{ .Values.configurationSpec.cniConf.nonPrimaryCni | default true }} |
Signed-off-by: Renuka Devi Rajendran <renuka.rajendran@suse.com>
rrajendran17
force-pushed
the
bump-kubeovn1.15.0
branch
from
2588de5 to
60b0628
Compare
1 participant
Problem:*
Kubeovn operator templates are are per older upstream version v1.14.10
Solution:
kubeovn operator templates (configuration, crd and values) must be updated to include new configuration values from upstream v1.15.0 kubeovn version
Related Issue:
harvester/harvester#9828
Test plan:
1.Install Harvester with v1.7.0
2.Update the image to custom image of kubeovn-operator.
3.Verify non-primary-cni set as true in ovn-controller deployment
4.Verify if all ovn pods are running
5.Create overlay networks, subnets, vpcs,vms, test traffic between VMs
6.Verify VPC Nat Gateway CRs