Skip to content

Conversation

@CDA0
Copy link

@CDA0 CDA0 commented Nov 13, 2025

Problem:

I'd like to be able to use a cloud config from a secret.

Solution:

Add configuration options for volumes and volume mounts for the deployment.

Related Issue(s):

Issue #9503 harvester/harvester#9503

Test plan:

run

  • helm template test . --namespace kube-system
  • helm template test . --namespace kube-system --set 'cloudConfig.hostPath=/var/lib/test'
  • helm template test . --namespace kube-system --set 'cloudConfig.secretName=harvester-cloud-config'

ensure output is as expected

Additional documentation or context

@ibrokethecloud
Copy link
Contributor

@CDA0 could you please sign off on the commit

Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CDA0 Thanks for the PR. IIUC, the cloudConfig.hostPath is similar as cloudConfigPath. I think we can just add cloudConfigSecret.

@CDA0
Copy link
Author

CDA0 commented Nov 14, 2025

@FrankYang0529 I am happy to do that, before I do I just wanted to explain why.

It starts to bring things in line with the csi driver, though there is other work to make it fully standardised

@w13915984028
Copy link
Member

@CDA0 Need controller also some changes to adapt to this new secret config, when yes, do you have the related PR to review together? thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants