Update README and add an example of chart bumping #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w13915984028
force-pushed
the
updatereadme
branch
from
2de6305 to
a0f4060
Compare
Signed-off-by: Jian Wang <jian.wang@suse.com>
w13915984028
force-pushed
the
updatereadme
branch
from
a0f4060 to
74eba4c
Compare
Contributor
Vicente-Cheng
left a comment
Vicente-Cheng
left a comment
There was a problem hiding this comment.
just some nits, overall LGTM.
Thanks for the detailed information on how to resolve the error.
| @@ -1,5 +1,4 @@ | |||
| # Harvester Charts | |||
|  | |||
Contributor
There was a problem hiding this comment.
I am not sure what it was used for before, and could we fix the broken image?
|
|
||
| e.g. https://github.com/harvester/charts/pull/229 | ||
|
|
||
| merge to `master` branch |
Contributor
There was a problem hiding this comment.
I thought we merged master because the chart content changed? If so, could we provide a more specific description here?
|
|
||
| :::note | ||
|
|
||
| The Rancher version `103.0.0` needs to increase to a next version like `103.0.1` if `103.0.0` has been used, otherwise, the `index.yaml` will not be updated. |
Contributor
There was a problem hiding this comment.
could we refer to their readme section (https://github.com/rancher/charts?tab=readme-ov-file#upstream-charts/) for more detailed info?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: harvester/harvester#5866
The document writes down all the detailed steps to release a chart and bump it to upstream.