Skip to content

Conversation

@andangrd
Copy link

Add IOS Version

screen shot 2018-10-27 at 11 55 16 pm

add documentation to run app for IOS version
add documentation to run app for IOS version
A React Native Web app that fetches GitHub API.

- Run on Android and Web 🎉
- Run on Android, IOS and Web 🎉
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Owner

@haruelrovix haruelrovix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andangrd Thanks for your contribution! 👏 Could you please revert unnecessary changes related to Android and resolve the merge conflicts? Thanks.

}

dependencies {
compile project(':react-native-vector-icons')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andangrd could you please revert this file? These changes are unnecessary. It's already there, using implementation instead of compile.

    implementation project(':appcenter')	
    implementation project(':appcenter-analytics')	
    implementation project(':appcenter-crashes')	
    implementation project(':react-native-vector-icons')

protected List<ReactPackage> getPackages() {
return Arrays.<ReactPackage>asList(
new MainReactPackage(),
new VectorIconsPackage(),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andangrd please revert these changes.

@@ -1,4 +1,7 @@
rootProject.name = 'creaternwapp'
include ':react-native-vector-icons'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haruelrovix unnecessary changes. Please revert this.

``` $ yarn add appcenter appcenter-analytics appcenter-crashes --exact ```
3. Link the plugins to the React Native app by using the react-native link command.
```
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

a bit messy, sir.
let me update it first.. :D

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andangrd yeah, seems react-native link doesn't care whether the package already exists or not.

2. [AppCenter](https://docs.microsoft.com/en-us/appcenter/)
3. [AppCenter for React Native](https://docs.microsoft.com/en-us/appcenter/sdk/getting-started/react-native)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andangrd feel free to add this section if you want.

Suggested change
## Contributors
- [haruelrovix](https://github.com/haruelrovix)
- [andangrd](https://github.com/andangrd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants