Open
Conversation
Adds comprehensive unit tests for `neuroscope/cli.py` to ensure proper argument parsing, command routing, and correct behavior of `main()`, `run_server()`, `run_demo()`, and `show_version()`. Mocking is used heavily to verify behavior deterministically without the need to bind network ports, load slow machine learning framework binaries, or start infinite sleep loops. Co-authored-by: harshithluc073 <101515387+harshithluc073@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What: The CLI entry point
neuroscope/cli.pywas missing test coverage.📊 Coverage: Added tests for:
main()invocation with no arguments, or with valid server/demo/version arguments.run_server()to verify thatNeuroScopeServerinstances are correctly instantiated and.start()/.stop()sequences happen on userKeyboardInterrupt.run_demo()with ML model permutations (mlp,cnn,transformer).run_demo()error handling whentorchis not installed on the system.show_version()to ensure the package version is printed.✨ Result: Substantial improvement in test coverage for CLI routing logic. Changes are isolated to tests and do not introduce regressions.
PR created automatically by Jules for task 14798355343238338772 started by @harshithluc073