Skip to content

Conversation

@PathogenDavid
Copy link
Contributor

  • Removed unnecessary GitHub token, asserted the contents write permission instead
  • Fixed setup-uv cache configuration
  • Bumped action versions (since I had to test everything anyway)
  • Tidied up indentation
  • Made workflow useful for pull requests
    • In particular, the generated table is now written to step summary output (Example)
    • The table is now only ever pushed when the workflow ran explicitly on main (rather than relying on the branch filter.)


on:
workflow_dispatch:
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ye this makes sense. Otherwise the action may fail after merging lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, ideally all CI-type workflows which run on push, pull_request, and without a branch filter. Anything else tends to delay finding problems which kind-of defeats the point.

@bruno-f-cruz
Copy link
Member

lgtm! Thanks for taking a look!

The step summary is a nice one. Didn't know you could do this.

@PathogenDavid
Copy link
Contributor Author

The step summary is a nice one. Didn't know you could do this.

Yup, it's very handy! My only wish is that GitHub made it was slightly more discoverable from the PR view without having the bot leave a comment or something.

We use it on Bonsai to list each package and its alignment with the previous release. (Example and relevant source code - the output is not very interesting right now since all the packages have changes for 2.9. I don't recommend imitating this though, the core Bonsai release process is very particular.)

There's a handful of little features like this that are nice for improving the output and letting steps interact with eachother.

(Including a bonus slightly undocumented command used to tell GitHub Actions how to recognize compiler errors. This is one of the reasons why you shouldn't skip actions/setup-dotnet and such.)

@bruno-f-cruz bruno-f-cruz merged commit d50df14 into harp-tech:main Apr 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants