Allow omitting interrupt number#109
Merged
glopesdev merged 2 commits intoharp-tech:mainfrom Mar 13, 2026
Merged
Conversation
When interrupt priority is set to off we allow omitting the interrupt number. If generating implementation code for pins with enabled interrupt priority we raise an error if no number is specified.
glopesdev
force-pushed
the
optional-interrupt-number
branch
from
034ea17 to
927e775
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When interrupt priority is set to
offwe allow omitting the interrupt number. If generating implementation code for pins with enabled interrupt priority, we raise an error if no number is specified.Regression testing was added to ensure correctness of roundtrip and code generation.