Skip to content

Ensure DO pin state is initialized correctly #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glopesdev merged 2 commits into from
Mar 13, 2026
Merged

Ensure DO pin state is initialized correctly #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05fd0b4
Add regression testing for IO initial state
glopesdev Mar 13, 2026
8aa9715
Ensure DO pin state is initialized correctly
glopesdev Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/AppRegsImpl.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,9 @@ if (outputPins.Count > 0)
foreach (var pin in outputPins)
{
var pinName = FirmwareNamingConvention.Instance.Apply(pin.Key);
var pinState = pin.Value.InitialState > 0 ? "set" : "clr";
#>
clr_<#= pinName #>;
<#= pinState #>_<#= pinName #>;
<#
}
#>
Expand Down
2 changes: 2 additions & 0 deletions tests/ExpectedOutput/device.app_ios_and_regs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ void init_ios(void)
io_pin2out(&PORTE, 7, OUT_IO_DIGITAL, IN_EN_IO_EN); // POKE1_VALVE
io_pin2out(&PORTF, 6, OUT_IO_DIGITAL, IN_EN_IO_EN); // POKE2_LED
io_pin2out(&PORTF, 7, OUT_IO_DIGITAL, IN_EN_IO_EN); // POKE2_VALVE
io_pin2out(&PORTC, 0, OUT_IO_WIREDAND, IN_EN_IO_EN); // CS0_1

/* Initialize output pins */
clr_DO3;
Expand All @@ -54,6 +55,7 @@ void init_ios(void)
clr_POKE1_VALVE;
clr_POKE2_LED;
clr_POKE2_VALVE;
set_CS0_1;
}

/************************************************************************/
Expand Down
7 changes: 7 additions & 0 deletions tests/ExpectedOutput/device.app_ios_and_regs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ void init_ios(void);
// POKE1_VALVE Description: Poke 1 Valve
// POKE2_LED Description: Poke 2 digital output
// POKE2_VALVE Description: Poke 2 Valve
// CS0_1 Description: CS0_1 / CS_ADC0

/* DO3 */
#define set_DO3 set_io(PORTC, 0)
Expand Down Expand Up @@ -119,6 +120,12 @@ void init_ios(void);
#define tgl_POKE2_VALVE toggle_io(PORTF, 7)
#define read_POKE2_VALVE read_io(PORTF, 7)

/* CS0_1 */
#define set_CS0_1 set_io(PORTC, 0)
#define clr_CS0_1 clear_io(PORTC, 0)
#define tgl_CS0_1 toggle_io(PORTC, 0)
#define read_CS0_1 read_io(PORTC, 0)

/************************************************************************/
/* Registers' structure */
/************************************************************************/
Expand Down
8 changes: 8 additions & 0 deletions tests/Metadata/device.ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,3 +164,11 @@ DI3:
interruptPriority: low
interruptNumber: 0
description: Input DI3
CS0_1:
port: PORTC
pinNumber: 0
direction: output
allowRead: true
pinMode: wiredAnd
initialState: high
description: CS0_1 / CS_ADC0
Loading