This repository was archived by the owner on Mar 2, 2019. It is now read-only.
Open
Conversation
|
This should work fine on the other distros. @haroldb Any possibility of merging this? |
|
I do see a problem with this. It isn't idempotent. The curl task should not have to run over and over if the runner is already installed. |
Author
|
I actually agree, and don't think the |
|
Take a look at one of the other forks: https://github.com/DBLaci/ansible-gitlab-runner They split the repo step out in to 14.04 and 16.04 when blocks. While not quite as flexible for the future, in the interests of visibility on this issue, it is worth pointing out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can confirm that @sloev's fix in issue #3 works for me on ubuntu 14.04 so I am making a PR out of it. However, I have not tested this with any other distros.