Fix: Update simple-icons dependency and logo component logic#21
Open
Madushansuriyabandara wants to merge 1 commit intoharish-sethuraman:masterfrom
Open
Fix: Update simple-icons dependency and logo component logic#21Madushansuriyabandara wants to merge 1 commit intoharish-sethuraman:masterfrom
Madushansuriyabandara wants to merge 1 commit intoharish-sethuraman:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Author
|
You can view the working deployment here, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where certain logos were not displaying correctly due to an outdated
simple-iconsdependency and changes in its API.Changes made:
simple-iconsto version 15.5.0 inpackage.json.src/logo-component/index.jsto use the newsimple-iconsAPI format (simpleIcons[iconName]) and updated the validation logic.Fixes #20 partially (Displays only langchain icon, other icons are not in the simple-icons package)