Per-bin downsampling (--point_stat) and symmetric sine-axis labels#27
Open
FrankS-2024 wants to merge 3 commits intoharbourlab:masterfrom
Open
Per-bin downsampling (--point_stat) and symmetric sine-axis labels#27FrankS-2024 wants to merge 3 commits intoharbourlab:masterfrom
FrankS-2024 wants to merge 3 commits intoharbourlab:masterfrom
Conversation
Ensure --point_stat controls how traces are downsampled into bins (max vs average) so spikes are preserved when requested. Make sine plots use a single shared y-scale so the positive and negative sides share the same magnitude and labels show symmetric values (e.g. 30 and -30 for a +30/-15 signal). Implemented per-bin aggregation in make_raw_data_filled so when --point_stat max is set a bin is reduced by max(...), otherwise the existing weighted average is used. Updated sine-track rendering to use get_relative_hight_custom(..., shared_max_value) for both control and treatment so amplitudes are scaled consistently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure --point_stat controls how traces are downsampled into bins (max vs average) so spikes are preserved when requested.
Make sine plots use a single shared y-scale so the positive and negative sides share the same magnitude and labels show symmetric values (e.g. 30 and -30 for a +30/-15 signal).
Implemented per-bin aggregation in make_raw_data_filled so when --point_stat max is set a bin is reduced by max(...), otherwise the existing weighted average is used.
Updated sine-track rendering to use get_relative_hight_custom(..., shared_max_value) for both control and treatment so amplitudes are scaled consistently.