Add storage option (cookie, local, session) to choose where to store the last used theme#17
Open
prantlf wants to merge 1 commit intoharborhoffer:masterfrom
Open
Add storage option (cookie, local, session) to choose where to store the last used theme#17prantlf wants to merge 1 commit intoharborhoffer:masterfrom
prantlf wants to merge 1 commit intoharborhoffer:masterfrom
Conversation
…the last used theme - cookie, localStorage or sessionStorage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last used theme needs not be stored as a cookie. While it could be inspected on the server side, usually it is useful on the client side only. In the usual scenario, it can be stored in localStorage or sessionStorage in the browser, which are available in all browsers for some time (IE8 and newer, e.g.). Also, it avoids increasing the cookie space and questions about security and cookies sent over the network.