Added tags to the title for common failure conditions#50
Open
glop102 wants to merge 3 commits intohappypandax:masterfrom
Open
Added tags to the title for common failure conditions#50glop102 wants to merge 3 commits intohappypandax:masterfrom
glop102 wants to merge 3 commits intohappypandax:masterfrom
Conversation
There are two common failure modes for e(x)hentai galleries 1) the gallery is expunged (eg copyright takedown) 2) the user is out of GP to download the archive Failure 2 is easily detectable as the response to getting the archive URL specifically reports such a failure. Failure 1 is more of an educated guess as the point of detection is getting a 404 even though we were given an archive key. Also a seemingly innocuous bug of the condition of which login service to use. The condition to choose x or non-x was backwards.
Author
|
Uhhh, whoops, i just realized i screwed up a little bit. |
This is only a failure because the flag seems to make zero sense. I have examples where things are marked as expunged but are still totally available on both domains, archives included. I also have examples where the archives are not available but the expunged flag is still false. I have not found a single example yet where a gallery is marked as expunged and is unavailable, ergo, the flag is useless.
The code was a bit silly with the indentation due to nesting things inside of if statements that never even had an else clause. Mostly code was just moved up in scope and the if statements were inverted to return early when meeting the pre-condition. Also added in comments for different sections and organized the sections to keep logical parts together.
Author
|
Well i gave up on using the "expunged" flag because it is nonsensical for when it is true or false. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two common failure modes for e(x)hentai galleries
Failure 2 is easily detectable as the response to getting the
archive URL specifically reports such a failure.
Failure 1 is more of an educated guess as the point of detection
is getting a 404 even though we were given an archive key.
Also a seemingly innocuous bug of the condition of which login
service to use. The condition to choose x or non-x was backwards.