Rebase release branch with Pikaday master #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove IE7 selector hacks.
Removing IE7 selector hack
`<script src="//path">` works great when you run a demo on a local webserver, but opening the demo file on your local will try to find jQuery on `file:///`. Adding `https:` or `http:` makes sure the demo will also run straight out of the zip.
As they are not needed in production, so they will not appear in installed package
Add `aria-label` config option
Mentioning the value for `setDefaultDate` is **Boolean**. It is not apparent from the documentation.
resets the date on keyboard delete or backspace
Otherwise npm will try to install Moment.js (even if it is optional) and because of this, Webpack automatically includes Moment.js in the bundle (Pikaday uses require('moment').
Users who still want to use Moment.js with Pikaday, can manually add it to their package.json file and everything will work as expected.
This change has the benefit that people who use bundle software don't need to change their config to ignore Moment.js and people who do want it usually add it to their package.json anyway.
Remove the Moment.js optional dependency from package.json
The formatting code example normalizes the date by subtracting one from the month value of the parts array. This value should be parsed as an integer before you subtract one from its value, which is the change made by this commit.
YamunaSubramanian
changed the title
Makes it so `!important` is not needed to override `position: static` which is set inline
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>
pragatheeswaranshf
force-pushed
the
release
branch
from
017d8ce to
634112a
Compare
There is a small typo in README.md, pikaday.js. Should read `text` rather than `tekst`.
docs: Fix simple typo, tekst -> text
….17.19 Bump lodash from 4.17.11 to 4.17.19
Prevent setting `position: static` inline when `container` option is passed
Make a variable for custom border-radius
Still think you shouldn't use it anymore..
Added has-event styling in scss file
Center Pika-button Text Alignment
Do not set position out of viewport
fix(accessibility): screen reader being forced to read headings on day change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.