allows cog to run from folders deeper than the project root #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is helpful if your project root/bin folder is not the same as where your typical PWD is. For example, we'll usually have the project root contain the bin folder but the `artisan` or `./craft` CLIs live inside a `html` directory. In this case you could now run `cog` from inside the `html` dir and it would still find `../bin/cog-*` files.
Collaborator
|
I'll check this out. |
dreadfullyposh
approved these changes
May 13, 2020
Collaborator
dreadfullyposh
left a comment
dreadfullyposh
left a comment
There was a problem hiding this comment.
Looks good to me. I have slight pause since the project .cogconfig could override the global and blow up the plugins you have installed, but not enough to hold up releasing this.
Contributor
Author
|
Agreed on the project |
Collaborator
|
SHIP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is helpful if your project root/bin folder is not the same as where your typical PWD is. For example, we'll usually have the project root contain the bin folder but the
artisanor./craftCLIs live inside ahtmldirectory. In this case you could now runcogfrom inside thehtmldir and it would still find../bin/cog-*files.To test this out the PR also adds a
cog issuecommand that you could run with a project. E.g., you could runcog issue 123inside a project directory and your browser would open with the correct URL.