Move explicit template instantiations to end of namespace to fix Clang symbol export#125
Open
star-hengxing wants to merge 1 commit intohaosulab:mainfrom
Open
Move explicit template instantiations to end of namespace to fix Clang symbol export#125star-hengxing wants to merge 1 commit intohaosulab:mainfrom
star-hengxing wants to merge 1 commit intohaosulab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang requires the definition of class template members to be visible before the explicit instantiation in order to correctly export the symbols. When the instantiation macros (e.g.,
DEFINE_TEMPLATE_PLANNING_WORLD) are placed at the beginning of the file, Clang fails to emit the necessary symbols, leading to "undefined reference" errors during linking.I have moved all explicit template instantiation macros to the end of the namespace (just before the closing brace) in the relevant
.cppfiles. This ensures that the full class template definition is available at the point of instantiation, which fixes the build on Clang while maintaining compatibility with GCC and MSVC.Note: These changes were applied automatically using a script to ensure consistency across all files.