Fix ApplicationLanguages.PrimaryLanguageOverride to allow clearing with empty string#26
Open
Fix ApplicationLanguages.PrimaryLanguageOverride to allow clearing with empty string#26
Conversation
…g to clear override - Modified validation logic in ApplicationLanguages.cpp to allow empty strings - Empty string input now clears the language override instead of throwing exception - Non-empty strings still validated using IsWellFormedTag() Fixes #17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary Fixes issue #17
where
ApplicationLanguages.PrimaryLanguageOverridecannot be unset once it has been set.Problem
The
PrimaryLanguageOverrideproperty validation logic was too strict - it required all input to be a well-formed language tag, including empty strings. This prevented users from clearing the language override by setting an empty string.Solution
Modified the validation logic in
ApplicationLanguages.cppto: