Skip to content

Conversation

@vjbaskar
Copy link
Member

@vjbaskar vjbaskar commented Dec 4, 2025

Description

Updated per sample rna-seq processing pipeline. The main change is python. notebook. Changed the scanpy.py command to accomodate the changes in the notebook.

Fixes # Issue with how one can use the same ipykernel and environment. Numpy deprecated function fixed with new scanpy env.

Type of change

  • 🐛 Bug fix (non-breaking change that resolves an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • ⚡ Optimisation (non-breaking improvement to performance or efficiency)
  • 🧩 Documentation (adds or improves documentation)
  • 🧱 Maintenance (refactor, dependency update, CI/CD, etc.)
  • 🔥 Breaking change (fix or feature that causes existing functionality to change)

Checklist

  • All tests pass (eg. pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)
  • Documentation updated (if required)

Copy link
Collaborator

@louisegrimble louisegrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vm11 found that the outputs generated (WS_wEMB10202354.h5ad) do not match sample ID that I inputted (HCA_SkO13919077) into solosis. I also inputted two samples and only 1 output was generated.

-rw-rw-r--  1 lg28 team298     96041 Dec  4 10:04 low_quality_cells_removed_in_preQC_WS_wEMB10202354.json
-rw-rw-r--  1 lg28 team298 213836117 Dec  4 10:14 WS_wEMB10202354.h5ad
-rw-rw-r--  1 lg28 team298   1137998 Dec  4 10:14 HCA_SkO13919077_HCA_SkO13919077.ipynb

## and here
$ ls -lrt reports
total 56
drwxr-xr-x 3 lg28 team298  804 Dec  4 10:08 WS_wEMB10202354
-rw-r--r-- 1 lg28 team298 2199 Dec  4 10:14 index.html

index.html also didn't generate any plots
image

Copilot AI review requested due to automatic review settings December 4, 2025 20:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@louisegrimble louisegrimble self-requested a review December 5, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants