-
Notifications
You must be signed in to change notification settings - Fork 0
Opt/cellbender h5 into scanpy cmd #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #199 +/- ##
==========================================
- Coverage 63.42% 62.80% -0.63%
==========================================
Files 28 22 -6
Lines 1277 1285 +8
==========================================
- Hits 810 807 -3
- Misses 467 478 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@barbaratpferreira Hi Barbara, this is a PR looking into how h5 files are read into the scanpy notebook. When we initially received the command/notebook from Vijay, the notebook was specifically reading in |
|
Adding @keerthi-priya-c to this conversation |
Hi @louisegrimble ! I agree too it should take any h5ad file submitted by user ie - either from cellranger or cellbender or soupX . If it helps in the notebook, I was testing a h5ad file from cellranger output folder when pulled in from irods-using solosis that's why it is "filtered_feature_bc_matrix.h5" in current code. but the code can be adapted to take in an h5 file in general (i.e. from celbender, cellranger or soupX etc.). I am happy to change it to adapt this or if you are already looking into this please feel free to change/adapt the code for taking in any h5ad file. |
Description
-Updated scanpy command to read in any h5 file
-Added validation for h5 file
-Added new input_utils definition
proces_h5_file()-made appropriate changes to merge_h5ad to read in the same metadata file
Fixes #198
Some examples of the validation working as expected:
Type of change
Checklist
pytest)pre-commit run --all-files)