Skip to content

Conversation

@dannda
Copy link
Contributor

@dannda dannda commented Nov 4, 2025

Description

refactor ObsmList params to useMemo to avoid race conditions

fixes #192

Type of change

  • πŸ› Bug fix (non-breaking change that resolves an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • ⚑ Optimisation (non-breaking improvement to performance or efficiency)
  • 🧩 Documentation (adds or improves documentation)
  • 🧱 Maintenance (refactor, dependency update, CI/CD, etc.)
  • πŸ”₯ Breaking change (fix or feature that causes existing functionality to change)

Checklist

  • All tests pass (eg. npm test)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)
  • Documentation updated (if required)

@dannda dannda requested review from Copilot and davehorsfall and removed request for Copilot November 4, 2025 10:29
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
βœ… Project coverage is 15.58%. Comparing base (5135761) to head (5a8b59b).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/lib/components/obsm-list/ObsmList.jsx 0.00% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #197   +/-   ##
=======================================
  Coverage   15.58%   15.58%           
=======================================
  Files          62       62           
  Lines        2092     2092           
  Branches      504      504           
=======================================
  Hits          326      326           
  Misses       1706     1706           
  Partials       60       60           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davehorsfall davehorsfall merged commit 2f1df57 into dev Nov 5, 2025
7 checks passed
@davehorsfall davehorsfall deleted the fix/scatterplot-bug branch November 5, 2025 13:33
@davehorsfall
Copy link
Member

πŸŽ‰ This PR is included in version 1.4.5 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants